-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposing setting for overriding template directory #4324
Conversation
Just to get the context for this:
How using the |
@blarghmatey did you see my question above? |
@arikfr sorry for the slow reply. I remember looking through the specifics of the logic flow when I first ran into this after first deploying Re:Dash ~2 years ago, but as I recall the short version is that if using the remote user login feature (https://github.com/getredash/redash/blob/master/redash/authentication/remote_user_auth.py) it is trying to load the The majority of the configuration can be seen in our Salt repository here: https://github.com/mitodl/salt-ops/blob/master/pillar/apps/redash.sls#L46-L74 Please let me know if you have any other questions. |
Just a quick ping to keep this PR visible @arikfr |
@blarghmatey I was about to merge this, but then noticed that it picked up a few unrelated commits. Can you create a branch that has only the settings updates and I will merge it? Thanks and sorry for keeping it open for so long. |
When using some of the customized login flows such as `REMOTE_USER` the deployed site breaks due to not finding template files. This change updated the app default to use the existing Flask templates directory rather than the compiled static assets directory which only contains an index.html file.
Thanks for following up on this @arikfr. I just rebased my branch off of master so it should be ready to merge. |
Merged 👍 |
When using some of the customized login flows such as `REMOTE_USER` the deployed site breaks due to not finding template files. This change updated the app default to use the existing Flask templates directory rather than the compiled static assets directory which only contains an index.html file.
#4189 What type of PR is this? (check all applicable)
Description
When using some of the customized login flows such as
REMOTE_USER
the deployed site breaks due to not finding template files. This change updated the app default to use the existing Flask templates directory rather than the compiled static assets directory which only contains an index.html file.